[
https://issues.apache.org/jira/browse/ARTEMIS-2990?focusedWorklogId=515460&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515460
]
ASF GitHub Bot logged work on ARTEMIS-2990:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/20 10:48
Start Date: 23/Nov/20 10:48
Worklog Time Spent: 10m
Work Description: gtully commented on a change in pull request #3352:
URL: https://github.com/apache/activemq-artemis/pull/3352#discussion_r528614122
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/AddressImpl.java
##########
@@ -84,6 +84,7 @@ public void addLinkedAddress(final Address address) {
if (linkedAddresses == null) {
linkedAddresses = PlatformDependent.hasUnsafe() ? new
NonBlockingHashSet<>() : new ConcurrentHashSet<>();
}
+ assert !linkedAddresses.contains(address);
Review comment:
in this case, the different behaviour is correct, just a waste. The code
now does the add/remove of linked addresses once, and if someone changes that,
the assert will fire. When I made that optimisation without the assert, it was
dropped in a few commits and none the wiser. an assert is a good win here imho.
It is suggesting the contract but it is not a fatal flaw to insert the same
value twice, just a waste.
@michaelandrepearce are you -1 on asserts or just this assert ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 515460)
Time Spent: 8h 20m (was: 8h 10m)
> optimise performance of wildcard address manager
> ------------------------------------------------
>
> Key: ARTEMIS-2990
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2990
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.16.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> A scenario test with lots of short lived concurrent wildcard subs
> demonstrates some bottlenecks in the wildcard address and binding manager.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
