[ 
https://issues.apache.org/jira/browse/ARTEMIS-3065?focusedWorklogId=535169&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-535169
 ]

ASF GitHub Bot logged work on ARTEMIS-3065:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Jan/21 03:01
            Start Date: 13/Jan/21 03:01
    Worklog Time Spent: 10m 
      Work Description: michaelandrepearce commented on a change in pull 
request #3406:
URL: https://github.com/apache/activemq-artemis/pull/3406#discussion_r556232797



##########
File path: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/paging/AmqpPagingTest.java
##########
@@ -118,4 +128,49 @@ public void testPaging() throws Exception {
       connection.close();
    }
 
+
+   @Test(timeout = 60000)
+   public void testNotBlockOnGlobalMaxSize() throws Exception {
+      final int MSG_SIZE = 1000;
+      final StringBuilder builder = new StringBuilder();
+      for (int i = 0; i < MSG_SIZE; i++) {
+         builder.append('0');
+      }
+      final String data = builder.toString();
+      final int MSG_COUNT = 3_000;
+
+      // sending size to explod max size
+      server.getPagingManager().addSize((int) ((PagingManagerImpl) 
server.getPagingManager()).getMaxSize());
+      server.getPagingManager().addSize(100_000);
+
+      server.getAddressSettingsRepository().addMatch("blockedQueue", new 
AddressSettings().setAddressFullMessagePolicy(AddressFullMessagePolicy.BLOCK));
+
+      ConnectionFactory factory = CFUtil.createConnectionFactory("AMQP", 
"tcp://localhost:5672");

Review comment:
       Can we make this test more generic as its already using just jms api and 
test the other protocols switching the connection factories to test them for 
this problem as we do in some other tests.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 535169)
    Time Spent: 40m  (was: 0.5h)

> AMQP Anonymous Producer will block on global max page when using only paged 
> messages
> ------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-3065
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3065
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.16.0
>            Reporter: Clebert Suconic
>            Assignee: Clebert Suconic
>            Priority: Major
>             Fix For: 2.17.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> This is in between an improvement and a bug fix...
>  
> When sending message to a AMQP anonymous producer, and all the messages on 
> the producer have full address as paged, will still block.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to