[
https://issues.apache.org/jira/browse/ARTEMIS-3065?focusedWorklogId=535461&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-535461
]
ASF GitHub Bot logged work on ARTEMIS-3065:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/21 15:12
Start Date: 13/Jan/21 15:12
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3406:
URL: https://github.com/apache/activemq-artemis/pull/3406#discussion_r556592747
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerReceiverContext.java
##########
@@ -184,6 +193,19 @@ protected void actualDelivery(AMQPMessage message,
Delivery delivery, Receiver r
}
}
+ private void validateAddressOnAnymousLink(AMQPMessage message) throws
Exception {
+ SimpleString newAddress = message.getAddressSimpleString();
+ if (newAddress != null && !newAddress.equals(lastAddress)) {
+ PagingStore newPageStore =
sessionSPI.getProtocolManager().getServer().getPagingManager().getPageStore(newAddress);
+ if (!addressAlreadyClashed && lastPageStore != null &&
lastPageStore.getAddressFullMessagePolicy() !=
newPageStore.getAddressFullMessagePolicy()) {
Review comment:
I thought about eventually extending the check into some of the sizes..
that's why I kept PageStore originally.
As the idea evolved I agree I don't need the pageStore any more.. I will
take it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 535461)
Time Spent: 1h 50m (was: 1h 40m)
> AMQP Anonymous Producer will block on global max page when using only paged
> messages
> ------------------------------------------------------------------------------------
>
> Key: ARTEMIS-3065
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3065
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.16.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.17.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> This is in between an improvement and a bug fix...
>
> When sending message to a AMQP anonymous producer, and all the messages on
> the producer have full address as paged, will still block.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
