[
https://issues.apache.org/jira/browse/ARTEMIS-3176?focusedWorklogId=564913&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-564913
]
ASF GitHub Bot logged work on ARTEMIS-3176:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/21 20:43
Start Date: 11/Mar/21 20:43
Worklog Time Spent: 10m
Work Description: jbertram commented on a change in pull request #3488:
URL: https://github.com/apache/activemq-artemis/pull/3488#discussion_r592707859
##########
File path:
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/JDBCDataSourceUtils.java
##########
@@ -29,7 +29,7 @@ public static DataSource getDataSource(String
dataSourceClassName, Map<String, O
ActiveMQJournalLogger.LOGGER.initializingJdbcDataSource(dataSourceClassName,
dataSourceProperties
.keySet()
.stream()
- .map(key -> key + "=" + dataSourceProperties.get(key))
+ .map(key -> key + "=" + (key.equals("password") ? "****" :
dataSourceProperties.get(key)))
Review comment:
It would only be uppercase if
[`org.apache.activemq.artemis.core.config.storage.DatabaseStorageConfiguration#getDataSource`](https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/config/storage/DatabaseStorageConfiguration.java#L170)
changes. It's hard-coded to use `password`.
I thought about making it a constant, but to be able to use it from
`org.apache.activemq.artemis.jdbc.store.drivers.JDBCDataSourceUtils` I'd have
to move it (and `org.apache.activemq.artemis.core.config.StoreConfiguration`)
out of the `artemis-server` module and into the `artemis-commons` module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 564913)
Time Spent: 0.5h (was: 20m)
> Don't log JDBC datasource "password" property
> ---------------------------------------------
>
> Key: ARTEMIS-3176
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3176
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
