[
https://issues.apache.org/jira/browse/ARTEMIS-3176?focusedWorklogId=565368&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-565368
]
ASF GitHub Bot logged work on ARTEMIS-3176:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Mar/21 15:50
Start Date: 12/Mar/21 15:50
Worklog Time Spent: 10m
Work Description: jbertram commented on a change in pull request #3488:
URL: https://github.com/apache/activemq-artemis/pull/3488#discussion_r593273448
##########
File path:
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/JDBCDataSourceUtils.java
##########
@@ -29,7 +29,7 @@ public static DataSource getDataSource(String
dataSourceClassName, Map<String, O
ActiveMQJournalLogger.LOGGER.initializingJdbcDataSource(dataSourceClassName,
dataSourceProperties
.keySet()
.stream()
- .map(key -> key + "=" + dataSourceProperties.get(key))
+ .map(key -> key + "=" + (key.equals("password") ? "****" :
dataSourceProperties.get(key)))
Review comment:
@brusdev, yes, I would assume that's theoretically possible. I will
update the PR to use `equalsIgnoreCase` instead of `equals`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 565368)
Time Spent: 1h 20m (was: 1h 10m)
> Don't log JDBC datasource "password" property
> ---------------------------------------------
>
> Key: ARTEMIS-3176
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3176
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
