[
https://issues.apache.org/jira/browse/ARTEMIS-3285?focusedWorklogId=598115&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-598115
]
ASF GitHub Bot logged work on ARTEMIS-3285:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/21 18:34
Start Date: 17/May/21 18:34
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3583:
URL: https://github.com/apache/activemq-artemis/pull/3583#discussion_r633548577
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/LastValueQueue.java
##########
@@ -259,6 +251,8 @@ public QueueConfiguration getQueueConfiguration() {
private void replaceLVQMessage(MessageReference ref, HolderReference hr) {
MessageReference oldRef = hr.getReference();
+// logger.info("Replacing " + oldRef + " with " + ref);
Review comment:
Commented code
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -133,7 +133,7 @@
protected static final int CRITICAL_CONSUMER = 3;
protected static final int CRITICAL_CHECK_DEPAGE = 4;
- private static final Logger logger = Logger.getLogger(QueueImpl.class);
+ protected static final Logger logger = Logger.getLogger(QueueImpl.class);
Review comment:
Should keep private and if a subclass wants to log then it makes its own
logger , so its logged against the right class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 598115)
Time Spent: 4h 50m (was: 4h 40m)
> Potential duplicate messages with LVQ + non-destructive
> -------------------------------------------------------
>
> Key: ARTEMIS-3285
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3285
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
