[
https://issues.apache.org/jira/browse/ARTEMIS-3285?focusedWorklogId=601365&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601365
]
ASF GitHub Bot logged work on ARTEMIS-3285:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/21 19:54
Start Date: 24/May/21 19:54
Worklog Time Spent: 10m
Work Description: jbertram commented on a change in pull request #3583:
URL: https://github.com/apache/activemq-artemis/pull/3583#discussion_r638234272
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/LastValueQueue.java
##########
@@ -56,9 +58,27 @@
@SuppressWarnings("ALL")
public class LastValueQueue extends QueueImpl {
+ private static final Logger logger = Logger.getLogger(LastValueQueue.class);
private final Map<SimpleString, HolderReference> map = new
ConcurrentHashMap<>();
private final SimpleString lastValueKey;
+ // only use this within synchronized methods or synchronized(this) blocks
+ protected volatile LinkedList<MessageReference> nextDeliveries = new
LinkedList<>();
Review comment:
Should be `final` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 601365)
Time Spent: 5.5h (was: 5h 20m)
> Potential duplicate messages with LVQ + non-destructive
> -------------------------------------------------------
>
> Key: ARTEMIS-3285
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3285
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
