[
https://issues.apache.org/jira/browse/ARTEMIS-3369?focusedWorklogId=618432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618432
]
ASF GitHub Bot logged work on ARTEMIS-3369:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jul/21 13:40
Start Date: 04/Jul/21 13:40
Worklog Time Spent: 10m
Work Description: michaelandrepearce edited a comment on pull request
#3638:
URL: https://github.com/apache/activemq-artemis/pull/3638#issuecomment-873590992
Re:
"
I was setting up some basic tests using the artemis producer and artemis
consumer to show how a client application can use the prefixes to get what it
wants. In this case these are low-level amqp clients that do not (all) have the
opportunity to set a capabilities value "queue" or "topic"; thus they rely on
using prefixes.
"
i would air significant caution here, the prefix scheme part of the
destination uri, could always be expanded and the broker should be able to do
this without worry of users abusing the prefix format. Destination scheme isnt
something that a user overlays on IMO. E.g. if we the broker decided on a new
prefix scheme for something new like a new routing theres no protection it
won't break your stuff.
If we wanted to expose custom queue configs not supported natively by
protocol on the destination i would be keen on repeating the solution used by
core and openwire using suffixed uri/url styled parameters. So we have
consistency in approach and can have some reuse so as new queue config/features
are added we only have one way to maintain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 618432)
Time Spent: 3h 20m (was: 3h 10m)
> CLI removes server-side prefixes from a given address
> -----------------------------------------------------
>
> Key: ARTEMIS-3369
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3369
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.17.0
> Reporter: Erwin Dondorp
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> The Artemis CLI variations {{producer}}, {{consumer}}, {{browse}} and
> {{transfer}}, all prepare a destination using function {{getDestination}}.
> However, this function also removes a prefix that it was not looking for. It
> tests for a topic prefix ({{topic://}}) and then removes any prefix that was
> present.
> It should explicitly test for the 2 prefixes it cares about ({{topic://}} and
> {{queue://}}) and then remove only a recognized prefix when it was present.
> PR is present.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
