[
https://issues.apache.org/jira/browse/ARTEMIS-3369?focusedWorklogId=618447&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618447
]
ASF GitHub Bot logged work on ARTEMIS-3369:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jul/21 18:45
Start Date: 04/Jul/21 18:45
Worklog Time Spent: 10m
Work Description: jbertram edited a comment on pull request #3638:
URL: https://github.com/apache/activemq-artemis/pull/3638#issuecomment-873618566
> I was setting up some basic tests using the `artemis producer` and
`artemis consumer` to show how a client application can use the prefixes to get
what it wants. In this case these are low-level amqp clients...
The problem here is that the `artemis producer` and `artemis consumer` are
*not* low-level AMQP clients. They use the JMS API (which is why they can
easily be switched between core and AMQP protocols). Therefore, they are not
suited to demonstrating prefix functionality for low-level clients. They are
just simple tools to producer and consume messages using the core or AMQP
protocol via the JMS API.
I realize that your change is relatively small and potentially viewed as
trivial, but the fundamental design of these commands is worth noting to
encourage proper usage and mitigate scope creep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 618447)
Time Spent: 3h 40m (was: 3.5h)
> CLI removes server-side prefixes from a given address
> -----------------------------------------------------
>
> Key: ARTEMIS-3369
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3369
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.17.0
> Reporter: Erwin Dondorp
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> The Artemis CLI variations {{producer}}, {{consumer}}, {{browse}} and
> {{transfer}}, all prepare a destination using function {{getDestination}}.
> However, this function also removes a prefix that it was not looking for. It
> tests for a topic prefix ({{topic://}}) and then removes any prefix that was
> present.
> It should explicitly test for the 2 prefixes it cares about ({{topic://}} and
> {{queue://}}) and then remove only a recognized prefix when it was present.
> PR is present.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
