[
https://issues.apache.org/jira/browse/ARTEMIS-3243?focusedWorklogId=627954&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627954
]
ASF GitHub Bot logged work on ARTEMIS-3243:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/21 19:21
Start Date: 26/Jul/21 19:21
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3633:
URL: https://github.com/apache/activemq-artemis/pull/3633#discussion_r676879293
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java
##########
@@ -511,22 +534,88 @@ private void connectSender(Queue queue,
sender.setProperties(mapProperties);
}
+ if (desiredCapabilities != null) {
+ sender.setDesiredCapabilities(desiredCapabilities);
+ }
+
AMQPOutgoingController outgoingInitializer = new
AMQPOutgoingController(queue, sender, sessionContext.getSessionSPI());
+ sender.open();
+
ProtonServerSenderContext senderContext = new
ProtonServerSenderContext(protonRemotingConnection.getAmqpConnection(), sender,
sessionContext, sessionContext.getSessionSPI(),
outgoingInitializer).setBeforeDelivery(beforeDeliver);
+ // This will be done on the remote open
+ sender.setContext(new Runnable() {
+ @Override
+ public void run() {
Review comment:
@gemmellr I could not figure out what you said about commented out
code... what code you were referring to?
I am changing the tests on ValidateAMQPErrorsTest to
setTarget(getRemoteTarget()) and adding a check if the remote is null for this.
this is a bit beyond the original intent of this PR.. which was more towards
the dual mirror addition than this kind of check.
I will add these as part of this PR, but we can improve this as part of a
separate JIRA / PR. you ok with that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 627954)
Time Spent: 29h 10m (was: 29h)
> Enhance AMQP Mirror support with dual mirror
> --------------------------------------------
>
> Key: ARTEMIS-3243
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3243
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.17.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 29h 10m
> Remaining Estimate: 0h
>
> at the current Mirror version, we can only mirror into a single direction.
> With this enhancement the two (or more brokers) would be connected to each
> other, each one having its own ID, and each one would send updates to the
> other broker.
> The outcome is that if you just transferred producers and consumers from one
> broker into the other, the fallback would be automatic and simple. No need to
> disable and enable mirror options.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
