[
https://issues.apache.org/jira/browse/ARTEMIS-3243?focusedWorklogId=628284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-628284
]
ASF GitHub Bot logged work on ARTEMIS-3243:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jul/21 09:08
Start Date: 27/Jul/21 09:08
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3633:
URL: https://github.com/apache/activemq-artemis/pull/3633#discussion_r677264925
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java
##########
@@ -511,22 +534,88 @@ private void connectSender(Queue queue,
sender.setProperties(mapProperties);
}
+ if (desiredCapabilities != null) {
+ sender.setDesiredCapabilities(desiredCapabilities);
+ }
+
AMQPOutgoingController outgoingInitializer = new
AMQPOutgoingController(queue, sender, sessionContext.getSessionSPI());
+ sender.open();
+
ProtonServerSenderContext senderContext = new
ProtonServerSenderContext(protonRemotingConnection.getAmqpConnection(), sender,
sessionContext, sessionContext.getSessionSPI(),
outgoingInitializer).setBeforeDelivery(beforeDeliver);
+ // This will be done on the remote open
+ sender.setContext(new Runnable() {
+ @Override
+ public void run() {
Review comment:
By 'the noted code' I meant:
https://github.com/gemmellr/activemq-artemis/commit/58b65283fdb1462c6ac01708ecfc4141dd079ea7#diff-18d73a3fc9014f71a70754aae490f5e0765b10fd76bb44daf6a50e5cea85dbc5R461-R467
The latter bit of my comment had a mistake, where I said 'when that code was
uncommented' it should have been 'when that code was commented'( i.e removed
per the notes).
I think its good to add handling the null terminus in this PR at least, when
its already adding a bunch of stuff in that exact space that could make it
otherwise misbehave and mislead folks with unhelpful errors if it
didnt....though I wouldnt really consider fully handling the basic link refusal
beyond the scope of the PR given its exactly how the broker would e.g refuse it
due to permissions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 628284)
Time Spent: 29h 20m (was: 29h 10m)
> Enhance AMQP Mirror support with dual mirror
> --------------------------------------------
>
> Key: ARTEMIS-3243
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3243
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.17.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 29h 20m
> Remaining Estimate: 0h
>
> at the current Mirror version, we can only mirror into a single direction.
> With this enhancement the two (or more brokers) would be connected to each
> other, each one having its own ID, and each one would send updates to the
> other broker.
> The outcome is that if you just transferred producers and consumers from one
> broker into the other, the fallback would be automatic and simple. No need to
> disable and enable mirror options.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
