[
https://issues.apache.org/jira/browse/ARTEMIS-3449?focusedWorklogId=647179&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-647179
]
ASF GitHub Bot logged work on ARTEMIS-3449:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Sep/21 04:27
Start Date: 07/Sep/21 04:27
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #3711:
URL: https://github.com/apache/activemq-artemis/pull/3711#issuecomment-913981275
@gemmellr @clebertsuconic
Going to merge the PR of Robbie on this branch, thanks
Side note: `AMQPLargeMessage` contains some dead code eg
```java
public void openLargeMessage() throws Exception {
this.parsingData = new AmqpReadableBuffer(largeBody.map());
}
public void closeLargeMessage() throws Exception {
largeBody.releaseResources(false, true);
parsingData.freeDirectBuffer();
parsingData = null;
}
```
and `private volatile AmqpReadableBuffer parsingData;` as well, given that
isn't used anymore, can be removed from
```java
@Override
public ReadableBuffer getData() {
if (parsingData == null) {
throw new RuntimeException("AMQP Large Message is not open");
}
return parsingData;
}
```
But `getData` seems heavily used by `AMQPStandardMessage`: going to get rid
of the dead code soon in a separate commit, but need some feedback to not break
anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 647179)
Time Spent: 10h (was: 9h 50m)
> Speedup AMQP large message streaming
> ------------------------------------
>
> Key: ARTEMIS-3449
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3449
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Time Spent: 10h
> Remaining Estimate: 0h
>
> AMQP is using unpooled heap ByteBuffer(s) to stream AMQP large messages:
> given that the underline NIO sequential file can both use FileChannel or
> RandomAccessFile (depending if the ByteBuffer used is direct/heap based),
> both approaches would benefit from using Netty pooled direct buffers and save
> additional copies (performed by RandomAccessFile) to happen, reducing GC too.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
