[ 
https://issues.apache.org/jira/browse/ARTEMIS-3475?focusedWorklogId=650194&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650194
 ]

ASF GitHub Bot logged work on ARTEMIS-3475:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Sep/21 18:52
            Start Date: 13/Sep/21 18:52
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic merged pull request #3744:
URL: https://github.com/apache/activemq-artemis/pull/3744


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 650194)
    Time Spent: 20m  (was: 10m)

> Possible recursion on PacketImpl::toString
> ------------------------------------------
>
>                 Key: ARTEMIS-3475
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3475
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Clebert Suconic
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> This is a mix of a bug and a task...
> classes extending Packet on core client are using a method named 
> getParentString() on the toString();
> The initial intent was to be simple and never to abuse inheritance on the 
> getParentString();
> Recent iteration on the code added a few occasions with toString() calling 
> getParentString() calling toString() what caused a recursive loop.
> I'm making this simpler. by introducing a getPacketString() on PacketImpl 
> where every extension of PacketImpl to simply call super.getParentString();
> Even though it still possible for someone to call itself on 
> getParentString(), at least it would be clearer and easier to catch on 
> revisions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to