[
https://issues.apache.org/jira/browse/ARTEMIS-3556?focusedWorklogId=678068&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-678068
]
ASF GitHub Bot logged work on ARTEMIS-3556:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/21 10:38
Start Date: 06/Nov/21 10:38
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3841:
URL: https://github.com/apache/activemq-artemis/pull/3841#discussion_r744110439
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/openmbean/MessageOpenTypeFactory.java
##########
@@ -123,6 +124,7 @@ protected void init() throws OpenDataException {
public Map<String, Object> getFields(M m, int valueSizeLimit, int
deliveryCount) throws OpenDataException {
Map<String, Object> rc = new HashMap<>();
rc.put(CompositeDataConstants.MESSAGE_ID, "" + m.getMessageID());
+ rc.put(CompositeDataConstants.PROTOCOL, m.getClass().getSimpleName());
Review comment:
This is a bit dangerous as it exposes class name to api, can we make
this something more explicit e.g. add interface to message api such as
(getProtocol) and then for the protocol implementation classes to implement
that returning a constant value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 678068)
Time Spent: 20m (was: 10m)
> Artemis console should show the message protocol
> ------------------------------------------------
>
> Key: ARTEMIS-3556
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3556
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: 2.20.0
> Reporter: Erwin Dondorp
> Priority: Minor
> Attachments: image-2021-11-05-23-07-36-340.png, screenshot-1.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When browsing messages in the Artemis Console, the page does not show the
> message protocol. Expert users could derive that information from the
> available message keys, but there is no formal indication of the message
> protocol.
> I have prepared a PR that shows the message protocol in the "Headers" table
> when viewing message details. The new field is "protocol".
> Instead of providing a descriptive text for each protocol, I kept it simple
> and used just the (short) java class name.
> The following class diagram shows which protocols may be shown:
> !image-2021-11-05-23-07-36-340.png!
> my guess is that only AMQPStandardMessage, AMQPLargeMessage, OpenwireMessage
> and CoreMessage can occur during normal use.
> sample:
> (TO BE UPDATED)
> !screenshot-1.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
