[
https://issues.apache.org/jira/browse/ARTEMIS-3556?focusedWorklogId=678753&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-678753
]
ASF GitHub Bot logged work on ARTEMIS-3556:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/21 21:13
Start Date: 08/Nov/21 21:13
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3841:
URL: https://github.com/apache/activemq-artemis/pull/3841#discussion_r745096534
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/openmbean/MessageOpenTypeFactory.java
##########
@@ -123,6 +124,7 @@ protected void init() throws OpenDataException {
public Map<String, Object> getFields(M m, int valueSizeLimit, int
deliveryCount) throws OpenDataException {
Map<String, Object> rc = new HashMap<>();
rc.put(CompositeDataConstants.MESSAGE_ID, "" + m.getMessageID());
+ rc.put(CompositeDataConstants.PROTOCOL, m.getClass().getSimpleName());
Review comment:
we could add a method on Message to return a more user friendly word?
on Message:
public String getProtocol();
then on core you return "CORE" and AMQP you return "AMQP"
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 678753)
Time Spent: 1h (was: 50m)
> Artemis console should show the message protocol
> ------------------------------------------------
>
> Key: ARTEMIS-3556
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3556
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: 2.20.0
> Reporter: Erwin Dondorp
> Priority: Minor
> Attachments: image-2021-11-05-23-07-36-340.png, screenshot-3.png
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When browsing messages in the Artemis Console, the page does not show the
> message protocol. Expert users could derive that information from the
> available message keys, but there is no formal indication of the message
> protocol.
> I have prepared a PR that shows the message protocol in the "Headers" table
> when viewing message details. The new field is "protocol".
> For each message type, the well-know protocol code is shown.
> The following class diagram shows which protocols may be shown (please ignore
> the interfaces and abstract classes):
> !image-2021-11-05-23-07-36-340.png!
> my guess is that only AMQP(Standard/Large)Message, OpenwireMessage and
> CoreMessage can occur during normal use.
> other protocol types are technically possible, these will show their java
> class name.
> since the protocol is technically not a property of the message, there are
> valid arguments for showing this differently. but this is by far the simplest
> visualization.
> sample:
> !screenshot-3.png!
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
