[
https://issues.apache.org/jira/browse/ARTEMIS-3576?focusedWorklogId=687426&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687426
]
ASF GitHub Bot logged work on ARTEMIS-3576:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/21 16:41
Start Date: 29/Nov/21 16:41
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3854:
URL: https://github.com/apache/activemq-artemis/pull/3854#discussion_r758542634
##########
File path:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java
##########
@@ -853,10 +853,14 @@ public boolean waitCompletionOnStream(final long
timeWait) throws JMSException {
@Override
public String toString() {
StringBuffer sb = new StringBuffer("ActiveMQMessage[");
- sb.append(getJMSMessageID());
- sb.append("]:");
- sb.append(message.isDurable() ? "PERSISTENT" : "NON-PERSISTENT");
- sb.append("/" + message.toString());
+ if (message != null) {
Review comment:
the default constructor is used for decoding.. a toString should not be
called between constructing and decoding..
although there wouldn't be harm on fixing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 687426)
Time Spent: 50m (was: 40m)
> Fix toString methods throwing exceptions
> ----------------------------------------
>
> Key: ARTEMIS-3576
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3576
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> A toString method should never throw any exceptions.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
