[
https://issues.apache.org/jira/browse/ARTEMIS-3576?focusedWorklogId=689376&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-689376
]
ASF GitHub Bot logged work on ARTEMIS-3576:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Dec/21 15:02
Start Date: 02/Dec/21 15:02
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3865:
URL: https://github.com/apache/activemq-artemis/pull/3865#discussion_r761178893
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java
##########
@@ -143,7 +143,7 @@
private volatile boolean stopPingingAfterOne;
- private volatile boolean closed;
+ private volatile boolean closed = true;
Review comment:
This change stops the CSFI cleanup logging? Guess that means the test
was actually failing to create the CSFI and call toString() on it, and yet the
finalizer was still logging the stack anyway? Must admit I didnt know that was
possible...but googling, seems it is. Another reason they are being nuked hehe.
I think I would [ab]use the _finalizeCheck_ boolean for this rather than
_closed_ given that its specifically for that behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 689376)
Time Spent: 2h (was: 1h 50m)
> Fix toString methods throwing exceptions
> ----------------------------------------
>
> Key: ARTEMIS-3576
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3576
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Minor
> Time Spent: 2h
> Remaining Estimate: 0h
>
> A toString method should never throw any exceptions.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
