[
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=737796&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737796
]
ASF GitHub Bot logged work on AMQNET-637:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Mar/22 21:27
Start Date: 07/Mar/22 21:27
Worklog Time Spent: 10m
Work Description: Havret commented on a change in pull request #18:
URL:
https://github.com/apache/activemq-nms-openwire/pull/18#discussion_r821117168
##########
File path: src/Util/Synchronization/TaskExtensions.cs
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+using System.Runtime.CompilerServices;
+using System.Threading.Tasks;
+
+namespace Apache.NMS.ActiveMQ.Util.Synchronization
+{
+ public static class TaskExtensions
+ {
+
+ public static T GetAsyncResult<T>(this Task<T> task)
+ {
+ return task.Await().GetAwaiter().GetResult();
Review comment:
When you're using `GetResult` there is no `await` so there is no point
of calling `ConfigureAwait`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 737796)
Time Spent: 16h 50m (was: 16h 40m)
> NMS 2.0
> -------
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
> Issue Type: Improvement
> Components: NMS
> Affects Versions: 1.8.0
> Reporter: Michael Andre Pearce
> Priority: Major
> Fix For: API-2.0.0
>
> Time Spent: 16h 50m
> Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the
> latest JMS 2.0 api
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
