[
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=737802&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737802
]
ASF GitHub Bot logged work on AMQNET-637:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Mar/22 21:33
Start Date: 07/Mar/22 21:33
Worklog Time Spent: 10m
Work Description: Havret commented on a change in pull request #18:
URL:
https://github.com/apache/activemq-nms-openwire/pull/18#discussion_r821120898
##########
File path: src/AdvisoryConsumer.cs
##########
@@ -44,7 +45,7 @@ internal AdvisoryConsumer(Connection connection, ConsumerId
consumerId) : base()
this.info.NoLocal = true;
this.connection.AddDispatcher(consumerId, this);
- this.connection.SyncRequest(this.info);
+ this.connection.SyncRequestAsync(this.info).GetAsyncResult();
Review comment:
From calling stack it seems this is used in async flow, but you're
blocking it here. I guess this should be changed, so first, you asynchronously
create a resource and then inject it here via the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 737802)
Time Spent: 17h (was: 16h 50m)
> NMS 2.0
> -------
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
> Issue Type: Improvement
> Components: NMS
> Affects Versions: 1.8.0
> Reporter: Michael Andre Pearce
> Priority: Major
> Fix For: API-2.0.0
>
> Time Spent: 17h
> Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the
> latest JMS 2.0 api
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
