[
https://issues.apache.org/jira/browse/ARTEMIS-3756?focusedWorklogId=754084&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-754084
]
ASF GitHub Bot logged work on ARTEMIS-3756:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Apr/22 13:45
Start Date: 07/Apr/22 13:45
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4009:
URL: https://github.com/apache/activemq-artemis/pull/4009#discussion_r845155383
##########
artemis-jms-client/src/main/java/org/apache/activemq/artemis/uri/TCPSchema.java:
##########
@@ -83,7 +83,7 @@ private void
checkIgnoredQueryFields(ActiveMQConnectionFactory factory, Map<Stri
if (!key.equals("ha") && !key.equals("type") &&
!TransportConstants.ALLOWABLE_CONNECTOR_KEYS.contains(key) &&
!factoryProperties.containsKey(key)) {
- ActiveMQClientLogger.LOGGER.connectionFactoryParameterIgnored(key);
+ ActiveMQClientLogger.LOGGER.connectionFactoryExtraParameter(key);
Review Comment:
just define a logger on TCPSchema, can call logger.debug here directly...
Issue Time Tracking
-------------------
Worklog Id: (was: 754084)
Time Spent: 0.5h (was: 20m)
> Connectors extra parameters are not passed throught the URI
> -----------------------------------------------------------
>
> Key: ARTEMIS-3756
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3756
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.21.0
> Reporter: Emmanuel Hugonnet
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Since the connectors extra parameters are not passed through the URI when
> obtaining a ConnectionFactory by JNDI it won't be using them. This may be an
> issue for any SPI on the client side since it doesn't get the configuration
> defined on the server side.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)