[
https://issues.apache.org/jira/browse/ARTEMIS-3756?focusedWorklogId=754089&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-754089
]
ASF GitHub Bot logged work on ARTEMIS-3756:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Apr/22 13:53
Start Date: 07/Apr/22 13:53
Worklog Time Spent: 10m
Work Description: ehsavoie commented on code in PR #4009:
URL: https://github.com/apache/activemq-artemis/pull/4009#discussion_r845163811
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java:
##########
@@ -425,10 +425,10 @@
format = Message.Format.MESSAGE_FORMAT)
void broadcastTimeout(int retry, int maxretry);
- @LogMessage(level = Logger.Level.WARN)
- @Message(id = 212078, value = "Connection factory parameter ignored {0}",
- format = Message.Format.MESSAGE_FORMAT)
- void connectionFactoryParameterIgnored(String parameterName);
Review Comment:
Is it ok to remove the id 212078 or should I keep it in the debug trace ?
There is a test looking for it.
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/SimpleJNDIClientTest.java:
##########
@@ -111,22 +115,26 @@ public void testEmptyConnectionFactoryString() throws
NamingException, JMSExcept
//IIB v10 assumes this property is mandatory and sets it to an empty
string when not specified
props.put("java.naming.provider.url", "");
- new InitialContext(props);//Must not throw an exception
-
+ Context ctx = new InitialContext(props);//Must not throw an exception
+ ctx.close();
}
@Test
public void testConnectionFactoryStringWithInvalidParameter() throws
Exception {
+ Level initialLevel =
LogManager.getLogManager().getLogger("org.apache.activemq.artemis.core.client").getLevel();
Review Comment:
ok
Issue Time Tracking
-------------------
Worklog Id: (was: 754089)
Time Spent: 50m (was: 40m)
> Connectors extra parameters are not passed throught the URI
> -----------------------------------------------------------
>
> Key: ARTEMIS-3756
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3756
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.21.0
> Reporter: Emmanuel Hugonnet
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Since the connectors extra parameters are not passed through the URI when
> obtaining a ConnectionFactory by JNDI it won't be using them. This may be an
> issue for any SPI on the client side since it doesn't get the configuration
> defined on the server side.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
