[
https://issues.apache.org/jira/browse/ARTEMIS-3707?focusedWorklogId=759333&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-759333
]
ASF GitHub Bot logged work on ARTEMIS-3707:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/22 15:49
Start Date: 20/Apr/22 15:49
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #3999:
URL: https://github.com/apache/activemq-artemis/pull/3999#discussion_r853011080
##########
examples/features/sub-modules/artemis-ra-rar/src/main/resources/ra.xml:
##########
@@ -23,7 +23,7 @@
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
+ http://www.apache.org/licenses/LICENSE-2.0
Review Comment:
This should be left as it was unless there is some compelling reason, thats
how it is in the original license text, and seems an unnecessary change.
##########
examples/features/sub-modules/artemis-ra-rar/src/main/resources/ra.xml:
##########
@@ -39,200 +39,196 @@
<config-property>
<description>
The transport type. Multiple connectors can be configured by using
a comma separated list,
- i.e.
org.apache.activemq.artemis.core.remoting.impl.invm.InVMConnectorFactory,org.apache.activemq.artemis.core.remoting.impl.invm.InVMConnectorFactory.
+ i.e.
+
org.apache.activemq.artemis.core.remoting.impl.invm.InVMConnectorFactory,org.apache.activemq.artemis.core.remoting.impl.invm.InVMConnectorFactory.
</description>
<config-property-name>ConnectorClassName</config-property-name>
<config-property-type>java.lang.String</config-property-type>
-
<config-property-value>org.apache.activemq.artemis.core.remoting.impl.netty.NettyConnectorFactory</config-property-value>
+
<config-property-value>org.apache.activemq.artemis.core.remoting.impl.netty.NettyConnectorFactory
+ </config-property-value>
</config-property>
<config-property>
<description>The transport configuration. These values must be in the
form of key=val;key=val;,
- if multiple connectors are used then each set must be separated by
a comma i.e. host=host1;port=61616,host=host2;port=61617.
+ if multiple connectors are used then each set must be separated by
a comma i.e.
+ host=host1;port=61616,host=host2;port=61617.
Each set of params maps to the connector classname specified.
</description>
<config-property-name>ConnectionParameters</config-property-name>
<config-property-type>java.lang.String</config-property-type>
-
<config-property-value>host=localhost,port=61616</config-property-value>
- </config-property>
-
- <!
Issue Time Tracking
-------------------
Worklog Id: (was: 759333)
Time Spent: 5h 40m (was: 5.5h)
> ResourceAdapter improvements
> ----------------------------
>
> Key: ARTEMIS-3707
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3707
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Waldi
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> Hi Everybody,
> I've tried to install the resourceAdapter in openliberty/WLP by myself. I've
> got in some troubles and fixed it by myself. Now, I would like to provide the
> modifications and a small piece of documentation of the resourceAdapter, if
> interested.
> * Sample config / project for openliberty/WLP
> * remove usage of the transactionManager in the resource adapter
> * fix the jakarta ra.xml namespaces and classnames
> * create a maven build for a rar archive with fewer dependencies and
> therefore a smaller footprint.
> I took notice of ARTEMIS-1487 and ARTEMIS-1614. In my opinion, with my
> contributions, we can close these issues. Can you tell me your thoughts and
> give me feedback?
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
