[
https://issues.apache.org/jira/browse/ARTEMIS-3707?focusedWorklogId=759347&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-759347
]
ASF GitHub Bot logged work on ARTEMIS-3707:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/22 16:01
Start Date: 20/Apr/22 16:01
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #3999:
URL:
https://github.com/apache/activemq-artemis/pull/3999#issuecomment-1104107531
In addition to the specific comments, and even elaborating on a couple of
them needing this, you really do need to rebase your changes against the
current main and squash them. Clebert previously gave some advice and even did
it for you at one point.
If you are still struggling doing that on the existing commits yourself you
could just use the [**current diff generated by
github**](https://patch-diff.githubusercontent.com/raw/apache/activemq-artemis/pull/3999.diff)
from all your changes so far work to apply it to a fresh branch from main
(then either update your current branch with that, or even open a new PR from
the new branch). I was able to download the diff and apply it directly to the
current main by just running `patch -p1 < 3999.diff`, with patch seeming to be
able to handle all the divergences itself using fuzz or offsets.
Issue Time Tracking
-------------------
Worklog Id: (was: 759347)
Time Spent: 5h 50m (was: 5h 40m)
> ResourceAdapter improvements
> ----------------------------
>
> Key: ARTEMIS-3707
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3707
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Waldi
> Priority: Major
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> Hi Everybody,
> I've tried to install the resourceAdapter in openliberty/WLP by myself. I've
> got in some troubles and fixed it by myself. Now, I would like to provide the
> modifications and a small piece of documentation of the resourceAdapter, if
> interested.
> * Sample config / project for openliberty/WLP
> * remove usage of the transactionManager in the resource adapter
> * fix the jakarta ra.xml namespaces and classnames
> * create a maven build for a rar archive with fewer dependencies and
> therefore a smaller footprint.
> I took notice of ARTEMIS-1487 and ARTEMIS-1614. In my opinion, with my
> contributions, we can close these issues. Can you tell me your thoughts and
> give me feedback?
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
