[
https://issues.apache.org/jira/browse/AMQ-8593?focusedWorklogId=765349&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765349
]
ASF GitHub Bot logged work on AMQ-8593:
---------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/22 09:57
Start Date: 03/May/22 09:57
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #835:
URL: https://github.com/apache/activemq/pull/835#issuecomment-1115923343
Since the docs say this mechanism is essentially an alternative means of
specifying static "failover:" transport usages with some unnamed options, and
the code seemingly confirms that from looking like just a loop for creating a
"failover://(looped-given-servers)?randomize=false&maxReconnectAttempts=0"
string, why not just name it more literally about what the config actually does
rather than trying to come up with some new abstractive topology name it seems
people have a hard time agreeing on.
The other config type is "static":
```
<networkConnector
uri="static:(tcp://host1:61616,tcp://host2:61616,tcp://..)"/>
```
The one under discussion differs in using "failover" transports. So what
about something like simply "staticfailover":
```
<networkConnector
uri="staticfailover:(tcp://host1:61616,tcp://host2:61616,tcp://..)"/>
```
Issue Time Tracking
-------------------
Worklog Id: (was: 765349)
Time Spent: 50m (was: 40m)
> Deprecate masterslave discovery agent and add a new leaderfollower discovery
> agent
> ----------------------------------------------------------------------------------
>
> Key: AMQ-8593
> URL: https://issues.apache.org/jira/browse/AMQ-8593
> Project: ActiveMQ
> Issue Type: Task
> Components: Network of Brokers
> Affects Versions: 5.17.2
> Reporter: Lucas Tétreault
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> This [tweet|https://twitter.com/owenblacker/status/1517156221207212032]
> raised the issue of non-inclusive terminology in the [AWS
> docs|https://docs.aws.amazon.com/amazon-mq/latest/developer-guide/amazon-mq-creating-configuring-network-of-brokers.html#creating-configuring-network-of-brokers-configure-network-connectors]
> and suggested that we should replace masterslave with an more inclusive name
> for the network connector transport. The AWS docs refer to a feature of
> ActiveMQ that is a convenience discovery agent:
> [https://activemq.apache.org/networks-of-brokers#masterslave-discovery]
> Replacing master/slave nomenclature in ActiveMQ was raised in July 2020
> AMQ-7514 and there have been some attempts at making some changes
> ([#679|https://github.com/apache/activemq/pull/679],
> [#714|https://github.com/apache/activemq/pull/714],
> [#788|https://github.com/apache/activemq/pull/788]) however we have not been
> able to come to an agreement on nomenclature so these efforts seem to have
> stalled out.
> If we are able to come to an agreement on nomenclature in this PR, we can
> move forward with removing more non-inclusive terminology on the website (I
> will follow up with some PRs to the website), in discussions with the
> community and of course in this codebase. This will remove adoption barriers
> and make ActiveMQ a more approachable and inclusive project for everyone!
> Other Apache projects such as Solr and Kafka have moved from master/slave to
> leader/follower. Leader/follower is also recommended by the
> [IETF|https://tools.ietf.org/id/draft-knodel-terminology-02.html] and
> [inclusivenaming.org|https://inclusivenaming.org/word-lists/tier-1/] which is
> supported by companies such as Cisco, Intel, and RedHat.
> If we can't come to an agreement on Leader/Follower or some other
> nomenclature I will, at the very least, create a follow up PR to remove the
> masterslave transport since it is just a convenience method to use
> static+failover with ?randomize=false&maxReconnectAttempts=0.
> This change leaves the masterslave: transport in place but provides a new
> alias leaderfollower: for now but we can easily remove it in 5.18.0.
> PR: https://github.com/apache/activemq/pull/835
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
