[
https://issues.apache.org/jira/browse/AMQ-8593?focusedWorklogId=765362&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765362
]
ASF GitHub Bot logged work on AMQ-8593:
---------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/22 11:09
Start Date: 03/May/22 11:09
Worklog Time Spent: 10m
Work Description: lucastetreault commented on PR #835:
URL: https://github.com/apache/activemq/pull/835#issuecomment-1115978234
> > I still think it would be valuable to try to get to a consensus on what
terms should replace master/slave. Any thoughts on how we can go about that?
>
> essentially requires a vote on dev mail list if you need to have a
decision, for the community and pmc to cast their votes.
>
> This said, for this change, is it even needed we make a new name.....? Why
not go with simply nested of existing names/url transports per same comment to
robbie and which i believe you even highlighted in slack yourself? Are we
really saving anything from telling users to put :
>
> (already supported) static:(failover:(uri1,uri2....
>
> vs
>
> staticfailover(uri1,uri2.....
I'm fine if the solution in the codebase is to simply remove the convenience
method. Even so, I think we need to agree on new terms. For example, to update
https://activemq.apache.org/networks-of-brokers#masterslave-discovery with new
instructions, how do I refer to the pair of brokers using shared storage if not
master/slave? I know Matt proposed some wording on slack that dances around the
problem, but there are lots of other places in the docs that could use updating
as well :)
Issue Time Tracking
-------------------
Worklog Id: (was: 765362)
Time Spent: 1h 40m (was: 1.5h)
> Deprecate masterslave discovery agent and add a new leaderfollower discovery
> agent
> ----------------------------------------------------------------------------------
>
> Key: AMQ-8593
> URL: https://issues.apache.org/jira/browse/AMQ-8593
> Project: ActiveMQ
> Issue Type: Task
> Components: Network of Brokers
> Affects Versions: 5.17.2
> Reporter: Lucas Tétreault
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> This [tweet|https://twitter.com/owenblacker/status/1517156221207212032]
> raised the issue of non-inclusive terminology in the [AWS
> docs|https://docs.aws.amazon.com/amazon-mq/latest/developer-guide/amazon-mq-creating-configuring-network-of-brokers.html#creating-configuring-network-of-brokers-configure-network-connectors]
> and suggested that we should replace masterslave with an more inclusive name
> for the network connector transport. The AWS docs refer to a feature of
> ActiveMQ that is a convenience discovery agent:
> [https://activemq.apache.org/networks-of-brokers#masterslave-discovery]
> Replacing master/slave nomenclature in ActiveMQ was raised in July 2020
> AMQ-7514 and there have been some attempts at making some changes
> ([#679|https://github.com/apache/activemq/pull/679],
> [#714|https://github.com/apache/activemq/pull/714],
> [#788|https://github.com/apache/activemq/pull/788]) however we have not been
> able to come to an agreement on nomenclature so these efforts seem to have
> stalled out.
> If we are able to come to an agreement on nomenclature in this PR, we can
> move forward with removing more non-inclusive terminology on the website (I
> will follow up with some PRs to the website), in discussions with the
> community and of course in this codebase. This will remove adoption barriers
> and make ActiveMQ a more approachable and inclusive project for everyone!
> Other Apache projects such as Solr and Kafka have moved from master/slave to
> leader/follower. Leader/follower is also recommended by the
> [IETF|https://tools.ietf.org/id/draft-knodel-terminology-02.html] and
> [inclusivenaming.org|https://inclusivenaming.org/word-lists/tier-1/] which is
> supported by companies such as Cisco, Intel, and RedHat.
> If we can't come to an agreement on Leader/Follower or some other
> nomenclature I will, at the very least, create a follow up PR to remove the
> masterslave transport since it is just a convenience method to use
> static+failover with ?randomize=false&maxReconnectAttempts=0.
> This change leaves the masterslave: transport in place but provides a new
> alias leaderfollower: for now but we can easily remove it in 5.18.0.
> PR: https://github.com/apache/activemq/pull/835
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
