[
https://issues.apache.org/jira/browse/ARTEMIS-3850?focusedWorklogId=780841&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-780841
]
ASF GitHub Bot logged work on ARTEMIS-3850:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/22 14:21
Start Date: 13/Jun/22 14:21
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4101:
URL: https://github.com/apache/activemq-artemis/pull/4101#discussion_r895778845
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationPageWriteMessage.java:
##########
@@ -25,45 +25,60 @@
public class ReplicationPageWriteMessage extends PacketImpl implements
MessagePacketI {
- private int pageNumber;
+ protected long pageNumber;
- private PagedMessage pagedMessage;
+ protected PagedMessage pagedMessage;
- public ReplicationPageWriteMessage() {
+ final boolean useLong;
+
+ public ReplicationPageWriteMessage(final boolean useLong) {
super(PacketImpl.REPLICATION_PAGE_WRITE);
+ this.useLong = useLong;
}
- public ReplicationPageWriteMessage(final PagedMessage pagedMessage, final
int pageNumber) {
- this();
+ public ReplicationPageWriteMessage(final PagedMessage pagedMessage, final
long pageNumber, final boolean useLong) {
+ this(useLong);
this.pageNumber = pageNumber;
this.pagedMessage = pagedMessage;
}
@Override
public int expectedEncodeSize() {
- return PACKET_HEADERS_SIZE +
- DataConstants.SIZE_INT + // buffer.writeInt(pageNumber);
- pagedMessage.getEncodeSize(); // pagedMessage.encode(buffer);
+ if (useLong) {
+ return PACKET_HEADERS_SIZE + DataConstants.SIZE_LONG + //
buffer.writeLong(pageNumber);
+ pagedMessage.getEncodeSize(); // pagedMessage.encode(buffer);
+ } else {
+ return PACKET_HEADERS_SIZE + DataConstants.SIZE_INT + //
buffer.writeInt(pageNumber);
+ pagedMessage.getEncodeSize(); // pagedMessage.encode(buffer);
+ }
}
@Override
public void encodeRest(final ActiveMQBuffer buffer) {
- buffer.writeInt(pageNumber);
+ if (useLong) {
+ buffer.writeLong(pageNumber);
+ } else {
+ buffer.writeInt((int) pageNumber);
Review Comment:
I don't think it needs to be validated, from now on we use longs.
Issue Time Tracking
-------------------
Worklog Id: (was: 780841)
Time Spent: 5h 20m (was: 5h 10m)
> Add Option to read messages into paging based on sizing and eliminate caching
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-3850
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3850
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Affects Versions: 2.22.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.24.0
>
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
