[
https://issues.apache.org/jira/browse/ARTEMIS-3850?focusedWorklogId=780204&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-780204
]
ASF GitHub Bot logged work on ARTEMIS-3850:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/22 05:05
Start Date: 10/Jun/22 05:05
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4101:
URL: https://github.com/apache/activemq-artemis/pull/4101#discussion_r894155237
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationPageEventMessage.java:
##########
@@ -54,7 +54,7 @@ public int expectedEncodeSize() {
@Override
public void encodeRest(final ActiveMQBuffer buffer) {
buffer.writeSimpleString(storeName);
- buffer.writeInt(pageNumber);
+ buffer.writeInt((int)pageNumber);
Review Comment:
I added versioning on the protocol, and a compatibility test where I'm
replicating between servers on different versions and using paging with
multiple protocols, and it's all good.
there's still a small possibility of a trunk if replication to or from a
previous version, but that will happen only if the user keeps running it
forever like this.. I don't think this is something that needs to be addressed.
Issue Time Tracking
-------------------
Worklog Id: (was: 780204)
Time Spent: 4h 10m (was: 4h)
> Add Option to read messages into paging based on sizing and eliminate caching
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-3850
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3850
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Affects Versions: 2.22.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.24.0
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
