[
https://issues.apache.org/jira/browse/ARTEMIS-3850?focusedWorklogId=781242&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781242
]
ASF GitHub Bot logged work on ARTEMIS-3850:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/22 14:20
Start Date: 14/Jun/22 14:20
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4101:
URL: https://github.com/apache/activemq-artemis/pull/4101#discussion_r896888056
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java:
##########
@@ -673,15 +738,24 @@ public Page removePage(int pageId) {
return null;
}
- Page page = createPage(pageId);
+ Page page = usePage(pageId);
- if (page.getFile().exists()) {
+ if (page != null && page.getFile().exists()) {
+ page.usageDown();
Review Comment:
..and if it isnt ==0? Its incremented every time through usePage()
regardless whether it came from usedPages or not. It just seems odd it always
does 'numberOfPages--' when it may not have decremented the use counter to 0.
Issue Time Tracking
-------------------
Worklog Id: (was: 781242)
Time Spent: 9h 50m (was: 9h 40m)
> Add Option to read messages into paging based on sizing and eliminate caching
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-3850
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3850
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Affects Versions: 2.22.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.24.0
>
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
