[
https://issues.apache.org/jira/browse/ARTEMIS-3850?focusedWorklogId=781255&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781255
]
ASF GitHub Bot logged work on ARTEMIS-3850:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/22 14:27
Start Date: 14/Jun/22 14:27
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4101:
URL: https://github.com/apache/activemq-artemis/pull/4101#discussion_r896897200
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java:
##########
@@ -673,15 +738,24 @@ public Page removePage(int pageId) {
return null;
}
- Page page = createPage(pageId);
+ Page page = usePage(pageId);
- if (page.getFile().exists()) {
+ if (page != null && page.getFile().exists()) {
+ page.usageDown();
Review Comment:
numberOfPages is orthogonal to usedPages here. it's just keeping the older
logic here as I did not change anything related to remove pages.
it could happen a cursor be passing through this and keeping the cache a bit
longer.
Issue Time Tracking
-------------------
Worklog Id: (was: 781255)
Time Spent: 10h 10m (was: 10h)
> Add Option to read messages into paging based on sizing and eliminate caching
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-3850
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3850
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Affects Versions: 2.22.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.24.0
>
> Time Spent: 10h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
