[ 
https://issues.apache.org/jira/browse/ARTEMIS-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557011#comment-17557011
 ] 

Justin Bertram commented on ARTEMIS-3867:
-----------------------------------------

>From what I can tell 
>{{org.apache.activemq.artemis.quorum.file.FileBasedPrimitiveManager}} is only 
>for testing purposes as indicated by [this 
>comment|https://github.com/apache/activemq-artemis/blob/224ca0d4d787fcfcc5e767bd889e3e8e48377737/artemis-quorum-ri/src/main/java/org/apache/activemq/artemis/quorum/file/FileBasedPrimitiveManager.java#L34]:
{code:java}
/**
 * This is an implementation suitable to be used just on unit tests and it 
won't attempt
 * to manage nor purge existing stale locks files. It's part of the tests 
life-cycle to properly
 * set-up and tear-down the environment.
 */{code}

That said, I can see a use-case where a file-based implementation of 
{{org.apache.activemq.artemis.quorum.DistributedPrimitiveManager}} would be 
useful (e.g. using NFS or a SAN to manage the lock between multiple brokers). 
Maybe this class could grow into that but it doesn't appear ready for such uses 
quite yet. It certainly isn't documented.

> ha-policy for replication won't work on Windows
> -----------------------------------------------
>
>                 Key: ARTEMIS-3867
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3867
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.23.0
>            Reporter: David Bennion
>            Priority: Major
>              Labels: high-availability
>
> FileBasedPrimitiveManager.java line 134 has  
> {code:java}
> getDistributedLock("ML:" + mutableLongId); {code}
> But the ':' is invalid on a Windows filesystem.  This should maybe be 
> replaced with an '_' or a '-'?



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to