[ 
https://issues.apache.org/jira/browse/ARTEMIS-3139?focusedWorklogId=786717&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-786717
 ]

ASF GitHub Bot logged work on ARTEMIS-3139:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Jun/22 16:52
            Start Date: 30/Jun/22 16:52
    Worklog Time Spent: 10m 
      Work Description: ryan-highley commented on code in PR #4122:
URL: https://github.com/apache/activemq-artemis/pull/4122#discussion_r911250825


##########
artemis-server/src/main/resources/schema/artemis-configuration.xsd:
##########
@@ -16,18 +16,23 @@
   limitations under the License.

Review Comment:
   If you would like me to replicate the original test files with an alternate 
modular include unit test scenario, I will do so. All the original test files 
work unaltered with the updated schema definition, as evidenced by the 
broker-connection and security-settings files. The existing config changes were 
to avoid creating a separate unit test class, which I will now create and 
submit.
   
   The attached screenshot shows one example of the IDE syntax support these 
schema definition changes enable when developing individual modular files, not 
just broker.xml files.
   
   
![XSDIncludeSyntaxSupport](https://user-images.githubusercontent.com/21245081/176733040-16ac65e0-b111-4937-9bff-9600289f4895.png)
   
   I would welcome other input here as well.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 786717)
    Time Spent: 5.5h  (was: 5h 20m)

> Anonymous types in artemis-configuration.xsd
> --------------------------------------------
>
>                 Key: ARTEMIS-3139
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3139
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Tuve Nordius
>            Priority: Major
>          Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> The artemis-configuration.xsd has a lot of anonymous types which makes it 
> hard to create a modulirized configuration. If I want to have diverts in a 
> seperate file I can do that but I cant get any validation/ help for any 
> editor. 
> example:
> I can do in an included file diverts.xml something like 
> {code:java}
> <diverts xmlns="urn:activemq:core">{code}
> I would like to do like bellow, but I can't since divertsType does not exist 
> other as an inline anonymous type.
>  
> {code:java}
> <diverts xmlns="urn:activemq:core"
>          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>          xsi:schemaLocation="urn:activemq:core 
> /schema/artemis-configuration.xsd"
>          xsi:type="divertsType" >
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to