[
https://issues.apache.org/jira/browse/ARTEMIS-3139?focusedWorklogId=786856&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-786856
]
ASF GitHub Bot logged work on ARTEMIS-3139:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jun/22 22:03
Start Date: 30/Jun/22 22:03
Worklog Time Spent: 10m
Work Description: ryan-highley commented on code in PR #4122:
URL: https://github.com/apache/activemq-artemis/pull/4122#discussion_r911477101
##########
artemis-server/src/test/resources/ConfigurationTest-xinclude-config-address-settings.xml:
##########
@@ -14,7 +14,10 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-<address-settings xmlns="urn:activemq:core">
+<address-settings xmlns="urn:activemq:core"
Review Comment:
Reverted all changes to the prior ConfigurationFile-xinclude-....xml unit
test resource files. Added a separate unit test class and many modular include
files for all top-level, non-trivial element types while still passing the
existing FileConfigurationTest and ConfigurationImplTest scenarios.
The ConfigurationImplTest#testSerialize() method makes a questionable
assumption regarding broker plugins in test configurations but I worked around
it to preserve the existing unit test while also including a modular broker
plugins file.
Issue Time Tracking
-------------------
Worklog Id: (was: 786856)
Time Spent: 6h 40m (was: 6.5h)
> Anonymous types in artemis-configuration.xsd
> --------------------------------------------
>
> Key: ARTEMIS-3139
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3139
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Tuve Nordius
> Priority: Major
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> The artemis-configuration.xsd has a lot of anonymous types which makes it
> hard to create a modulirized configuration. If I want to have diverts in a
> seperate file I can do that but I cant get any validation/ help for any
> editor.
> example:
> I can do in an included file diverts.xml something like
> {code:java}
> <diverts xmlns="urn:activemq:core">{code}
> I would like to do like bellow, but I can't since divertsType does not exist
> other as an inline anonymous type.
>
> {code:java}
> <diverts xmlns="urn:activemq:core"
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="urn:activemq:core
> /schema/artemis-configuration.xsd"
> xsi:type="divertsType" >
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
