[
https://issues.apache.org/jira/browse/ARTEMIS-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562220#comment-17562220
]
Robbie Gemmell edited comment on ARTEMIS-3883 at 7/5/22 12:29 PM:
------------------------------------------------------------------
There is an ldap example using version M20 of Directory, whereas the rest of
the build all uses the significantly newer AM25 version (the newer-still AM26
breaks things on recent JDKs and so cant be used). The example doesnt compile
with AM25 and in trying to get it to I wasnt able to make it work. Compiling
was simple enough but its not clear what to replace one call with and nothing
tried actually worked. Im not clear on what its really doing or why so I dont
know how to resolve. The tests elsewhere operate quite differently, using
annotations to create their serversm, and it wasnt obvious from there either
what could be changed in the examples embedding classes to make them work.
I'm attaching a WIP diff, [^ARTEMIS-3883-WIP-DS-version.diff], that hopefully
someone more familiar with the example/Directory bits could build on, as this
is probably the worst offender in terms of downloading duplicate stuff
effectively already used elsewhere.
was (Author: gemmellr):
There is an ldap example using version M20 of Directory, whereas the rest of
the build all uses the significantly newer AM25 version (the newer-still AM26
breaks things on recent JDKs and so cant be used). The example doesnt compile
with AM25 and in trying to get it to I wasnt able to make it work. Compiling
was simple enough but its not clear what to replace one call with and nothing
tried actually worked. Im not clear on what its really doing or why so I dont
know how to resolve. The tests
I'm attaching a WIP diff, [^ARTEMIS-3883-WIP-DS-version.diff], that hopefully
someone more familiar with the example/Directory bits could build on, as this
is probably the worst offender in terms of downloading duplicate stuff
effectively already used elsewhere.
> align various dependency versions used in build/test/examples
> -------------------------------------------------------------
>
> Key: ARTEMIS-3883
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3883
> Project: ActiveMQ Artemis
> Issue Type: Task
> Affects Versions: 2.23.1
> Reporter: Robbie Gemmell
> Priority: Major
> Fix For: 2.24.0
>
> Attachments: ARTEMIS-3883-WIP-DS-version.diff
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are cases where the build uses a particular dependency version, e.g as
> part of a component itself or during its tests, and then the examples also
> use that dependency but with a different version. This is due to not sharing
> a common definition of the version used, and/or not having
> dependencyManagement to govern it.
>
> This leads to the build unecessarily grabbing distinct versions of artifacts
> in cases, slowing the overall build and using more resources than needed.
> Where possible the versions should be aligned.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
