[
https://issues.apache.org/jira/browse/ARTEMIS-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562645#comment-17562645
]
Robbie Gemmell edited comment on ARTEMIS-3883 at 7/5/22 12:39 PM:
------------------------------------------------------------------
I had another look and still didnt get it going with the existing custom
classes for embedding directory. However when doing a simplifying-alternative
occurred to me: just do something very similar to what the tests elsewhere do.
I created a simple boiler plate test class thats executed with a one-liner from
the example main method, which allows it to use the Directory JUnit
integrations to manage a test server instance, and it then runs the example
code which no longer needs to manage any of those bits. The custom classes for
creating an embedded directory server can just be removed.
[https://github.com/apache/activemq-artemis/pull/4136]
was (Author: gemmellr):
I had another look and still didnt get it going with the existing custom
classes for embedding directory. However when doing a simplifying-alternative
occurred to me: just do something very similar to the tests elsewhere do. I
created a simple boiler plate test class thats from the example main method,
allows use of the Directory JUnit integrations to manage a test server etc, and
runs the example code. The custom classes for creating an embedded directory
server can just be removed.
https://github.com/apache/activemq-artemis/pull/4136
> align various dependency versions used in build/test/examples
> -------------------------------------------------------------
>
> Key: ARTEMIS-3883
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3883
> Project: ActiveMQ Artemis
> Issue Type: Task
> Affects Versions: 2.23.1
> Reporter: Robbie Gemmell
> Priority: Major
> Fix For: 2.24.0
>
> Attachments: ARTEMIS-3883-WIP-DS-version.diff
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are cases where the build uses a particular dependency version, e.g as
> part of a component itself or during its tests, and then the examples also
> use that dependency but with a different version. This is due to not sharing
> a common definition of the version used, and/or not having
> dependencyManagement to govern it.
>
> This leads to the build unecessarily grabbing distinct versions of artifacts
> in cases, slowing the overall build and using more resources than needed.
> Where possible the versions should be aligned.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
