[
https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=813406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-813406
]
ASF GitHub Bot logged work on ARTEMIS-4020:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/22 16:14
Start Date: 29/Sep/22 16:14
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #4237:
URL:
https://github.com/apache/activemq-artemis/pull/4237#issuecomment-1262504325
I cant unresolve things but I dont consider the 'can no longer tell which
mechanism failed' thing to be resolved. For that and the very similar 'which
login module is this logging for', the change significantly reduces the utility
of those log messages. They either need the log messages adjusted to actually
report what child class they are logging on behalf of, or would be better to
retain the existing behaviour, albeit implemented slightly differently...e.g by
supplying the class or the logger from the child 'user' class so the parent can
log on its behalf (e.g like Netty lets you do for its logging) rather than
relying on the getClass() in the abstract parent.
Issue Time Tracking
-------------------
Worklog Id: (was: 813406)
Time Spent: 5.5h (was: 5h 20m)
> switch to using SLF4J for logging API and use Log4j 2 for broker distribution
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-4020
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4020
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Robbie Gemmell
> Priority: Major
> Fix For: 2.27.0
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the
> code base, with end-uses supplying and configuring an SLF4J-supporting
> logging implementation of their choice based on their needs.
> For the client, applications will need to supply an SLF4J binding to a
> logging implementation of their choice to enable logging. An example of doing
> so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is
> given in (/will be, once the release is out) the [client logging
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application].
> For the broker, the assembly distribution will include [Log4J
> 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging
> implentation, with the "artemis create" CLI command used to create broker
> instances now creating a log4j2.properties configuration within the
> <broker-instance>/etc/ directory to configure Log4J. Details for upgrading an
> existing broker-instance is given in (/will be, once the release is out) the
> [version upgrade
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
