[
https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=813411&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-813411
]
ASF GitHub Bot logged work on ARTEMIS-4020:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/22 16:35
Start Date: 29/Sep/22 16:35
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #4237:
URL:
https://github.com/apache/activemq-artemis/pull/4237#issuecomment-1262527715
The precise implementation may have been a mistake, but there are other ways
to acheive the same effect, which isnt unusual. The logging before was more
useful than it will be with your change, where it will become less useful
becuase you cant actually distinguish which of multiple things it is on behalf
of.
You mentioned not being able to find where its logging (which per above is
effectively what the change itsealf does). Its relatively trivial to follow a
logger name of a specific subclass to a shared-implementation in its immediate
parent. There are multiple mechanisms or login module classes that some of
those shared-impl log statments could be for, and previously the logs would
inherently identified exactly which one it was happening for. With your change
they will instead all indicate the abstract parent, making it impossible to
tell what one the logging was for if there happens to be more than one in use
at the time.
Issue Time Tracking
-------------------
Worklog Id: (was: 813411)
Time Spent: 5h 50m (was: 5h 40m)
> switch to using SLF4J for logging API and use Log4j 2 for broker distribution
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-4020
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4020
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Robbie Gemmell
> Priority: Major
> Fix For: 2.27.0
>
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the
> code base, with end-uses supplying and configuring an SLF4J-supporting
> logging implementation of their choice based on their needs.
> For the client, applications will need to supply an SLF4J binding to a
> logging implementation of their choice to enable logging. An example of doing
> so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is
> given in (/will be, once the release is out) the [client logging
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application].
> For the broker, the assembly distribution will include [Log4J
> 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging
> implentation, with the "artemis create" CLI command used to create broker
> instances now creating a log4j2.properties configuration within the
> <broker-instance>/etc/ directory to configure Log4J. Details for upgrading an
> existing broker-instance is given in (/will be, once the release is out) the
> [version upgrade
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
