[ 
https://issues.apache.org/jira/browse/ARTEMIS-4025?focusedWorklogId=816044&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-816044
 ]

ASF GitHub Bot logged work on ARTEMIS-4025:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Oct/22 09:12
            Start Date: 12/Oct/22 09:12
    Worklog Time Spent: 10m 
      Work Description: gtully commented on code in PR #4241:
URL: https://github.com/apache/activemq-artemis/pull/4241#discussion_r993207211


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerStatus.java:
##########
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.core.server.impl;
+
+
+import java.util.HashMap;
+
+import org.apache.activemq.artemis.api.core.JsonUtil;
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.json.JsonObject;
+import org.apache.activemq.artemis.json.JsonObjectBuilder;
+import org.apache.activemq.artemis.utils.JsonLoader;
+
+public class ServerStatus {
+
+   private static final ServerStatus instance = new ServerStatus();
+
+   public static synchronized ServerStatus getInstanceFor(ActiveMQServerImpl 
activeMQServer) {
+      if (instance.server == null) {
+         instance.server = activeMQServer;
+         instance.immutableStateValues.put("version", 
instance.server.getVersion().getFullVersion());

Review Comment:
   I am going to leave the simple attributes, if we build up this some more, 
those names could be inferred.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 816044)
    Time Spent: 1.5h  (was: 1h 20m)

> properties config -  provide error status for invalid properties
> ----------------------------------------------------------------
>
>                 Key: ARTEMIS-4025
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4025
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Configuration
>    Affects Versions: 2.26.0
>            Reporter: Gary Tully
>            Assignee: Gary Tully
>            Priority: Major
>             Fix For: 2.27.0
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> following up on the availability of a [status json|ARTEMIS-4007] - trap any 
> errors from bean util property failure to apply, for any in invalid property. 
> Currently all failures to find setters are silently ignored.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to