[
https://issues.apache.org/jira/browse/ARTEMIS-4025?focusedWorklogId=817120&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-817120
]
ASF GitHub Bot logged work on ARTEMIS-4025:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Oct/22 18:12
Start Date: 14/Oct/22 18:12
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4258:
URL: https://github.com/apache/activemq-artemis/pull/4258#discussion_r996014119
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java:
##########
@@ -415,8 +415,27 @@ public class ConfigurationImpl implements Configuration,
Serializable {
* Parent folder for all data folders.
*/
private File artemisInstance;
- private transient JsonObject status =
JsonLoader.createObjectBuilder().build();
- private final transient Checksum checksum = new Adler32();
+ private transient JsonObject jsonStatus =
JsonLoader.createObjectBuilder().build();
+ private transient Checksum transientChecksum = null;
+
+
+ private JsonObject getJsonStatus() {
+ if (jsonStatus == null) {
+ jsonStatus = JsonLoader.createObjectBuilder().build();
+ }
+ return jsonStatus;
+ }
+
+ // Checksum would be otherwise final
+ // however some Quorum actiations are using Serialization to make a deep
copy of ConfigurationImpl and it would become null
+ // for that reason this i making the proper initialization when needed.
+ private Checksum getCheckSun() {
+ if (transientChecksum == null) {
+ transientChecksum = new Adler32();
+ }
+ return transientChecksum;
+ }
+
Review Comment:
@gtully please review this?
I just want to get the test suite back running again... so I will probably
merge this pretty fast... but if you have a better fix please commit on top of
this please?
Issue Time Tracking
-------------------
Worklog Id: (was: 817120)
Time Spent: 2h (was: 1h 50m)
> properties config - provide error status for invalid properties
> ----------------------------------------------------------------
>
> Key: ARTEMIS-4025
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4025
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 2.26.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Fix For: 2.27.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> following up on the availability of a [status json|ARTEMIS-4007] - trap any
> errors from bean util property failure to apply, for any in invalid property.
> Currently all failures to find setters are silently ignored.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
