[
https://issues.apache.org/jira/browse/ARTEMIS-4193?focusedWorklogId=849663&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-849663
]
ASF GitHub Bot logged work on ARTEMIS-4193:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Mar/23 19:37
Start Date: 07/Mar/23 19:37
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #4395:
URL: https://github.com/apache/activemq-artemis/pull/4395#discussion_r1128454402
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCounterRebuildManager.java:
##########
@@ -186,6 +189,7 @@ public void run() {
}
public void rebuild() throws Exception {
+ logger.info("Rebuilding " + pgStore.getStoreName());
Review Comment:
Should be using logger formatting as opposed to string concats.
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCounterRebuildManager.java:
##########
@@ -216,6 +220,11 @@ public void rebuild() throws Exception {
try (LinkedListIterator<PagedMessage> iter = msgs.iterator()) {
while (iter.hasNext()) {
PagedMessage msg = iter.next();
+ logger.info("Reading " + msg);
Review Comment:
Ditto
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/PagingManager.java:
##########
@@ -85,6 +86,11 @@ public interface PagingManager extends ActiveMQComponent,
HierarchicalRepository
void injectMonitor(FileStoreMonitor monitor) throws Exception;
+ /** Execute a runnable inside the PagingManager's executor */
Review Comment:
Having the default method that violates the intended contract of the method
as documented seems less than ideal. If the intention is to prevent having to
add this to other PagingManager implementations that won't ever have this
method invoked then throwing an UnsupportedOperationException would be better
because at least then you might notice that the method is being used and not
doing something on a thread that was unintended.
Issue Time Tracking
-------------------
Worklog Id: (was: 849663)
Time Spent: 0.5h (was: 20m)
> Interrupting Large Message Streaming with a server kill may leave orphaned
> files
> --------------------------------------------------------------------------------
>
> Key: ARTEMIS-4193
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4193
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.28.0
> Reporter: Clebert Suconic
> Priority: Major
> Fix For: 2.29.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> There's a schema in the journal to store pending records before a file is
> created.
> However the sync is not properly applied and if the server is killed it could
> leave a few messages orphaned in the file system.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
