[
https://issues.apache.org/jira/browse/ARTEMIS-4193?focusedWorklogId=849853&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-849853
]
ASF GitHub Bot logged work on ARTEMIS-4193:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Mar/23 16:47
Start Date: 08/Mar/23 16:47
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4395:
URL: https://github.com/apache/activemq-artemis/pull/4395#discussion_r1129749688
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCounterRebuildManager.java:
##########
@@ -216,6 +219,10 @@ public void rebuild() throws Exception {
try (LinkedListIterator<PagedMessage> iter = msgs.iterator()) {
while (iter.hasNext()) {
PagedMessage msg = iter.next();
+ if (storedLargeMessages != null &&
msg.getMessage().isLargeMessage()) {
+ logger.debug("removing storedLargeMessage {}",
msg.getMessage().getMessageID());
Review Comment:
Thats a fair point, I had overlooked that...got drawn in by the others
around it having them.
Issue Time Tracking
-------------------
Worklog Id: (was: 849853)
Time Spent: 1h 20m (was: 1h 10m)
> Interrupting Large Message Streaming with a server kill may leave orphaned
> files
> --------------------------------------------------------------------------------
>
> Key: ARTEMIS-4193
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4193
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.28.0
> Reporter: Clebert Suconic
> Priority: Major
> Fix For: 2.29.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> There's a schema in the journal to store pending records before a file is
> created.
> However the sync is not properly applied and if the server is killed it could
> leave a few messages orphaned in the file system.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
