[
https://issues.apache.org/jira/browse/ARTEMIS-4251?focusedWorklogId=858924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-858924
]
ASF GitHub Bot logged work on ARTEMIS-4251:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/23 12:48
Start Date: 25/Apr/23 12:48
Worklog Time Spent: 10m
Work Description: gtully commented on code in PR #4447:
URL: https://github.com/apache/activemq-artemis/pull/4447#discussion_r1176456963
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ServerLocator.java:
##########
@@ -653,6 +653,21 @@ ClientSessionFactory
createSessionFactory(TransportConfiguration transportConfig
*/
int getInitialConnectAttempts();
+ /**
+ * Sets the maximum number of attempts to establish a connection after a
failed reconnection.
Review Comment:
should that be "failed connection" rather than "failed reconnection"
##########
docs/user-manual/en/client-reconnection.md:
##########
@@ -89,9 +89,20 @@ Client reconnection is configured using the following
parameters:
ridiculously large values. By setting this parameter you can set an upper
limit
on that value. The default value is `2000` milliseconds.
+- `ha`. This optional parameter determines weather the client will try to
+ reconnect to the backup node when the live node is not reachable.
+ The default value is `false`.
+ For more information on HA, please see [High Availability and
Failover](ha.md).
+
- `reconnectAttempts`. This optional parameter determines the total number of
- reconnect attempts to make before giving up and shutting down. A value of
- `-1` signifies an unlimited number of attempts. The default value is `0`.
+ reconnect attempts to make to the current live/backup pair before giving up.
Review Comment:
I am confused :-)
I thought failover was between live and backup
reconnect should first try to failover, then fall back to any connection to
eventually reconnect. these seems the opposite.
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ServerLocator.java:
##########
@@ -653,6 +653,21 @@ ClientSessionFactory
createSessionFactory(TransportConfiguration transportConfig
*/
int getInitialConnectAttempts();
+ /**
+ * Sets the maximum number of attempts to establish a connection after a
failed reconnection.
Review Comment:
maximum number of attempts to reconnect after a failure. But I may have this
wrong!
Issue Time Tracking
-------------------
Worklog Id: (was: 858924)
Time Spent: 0.5h (was: 20m)
> Support CORE client failover to other live servers
> --------------------------------------------------
>
> Key: ARTEMIS-4251
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4251
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The CORE clients support failover only reconnecting to the current
> live/backup pair. Improve the CORE client failover connecting to other live
> servers when all reconnect attempts fails, i.e. in a cluster composed of 2
> live servers, when the server to which the CORE client is connected goes down
> the CORE client should reconnect its sessions to the other liver broker.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
