[ https://issues.apache.org/jira/browse/ARTEMIS-4251?focusedWorklogId=858998&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-858998 ]
ASF GitHub Bot logged work on ARTEMIS-4251: ------------------------------------------- Author: ASF GitHub Bot Created on: 25/Apr/23 18:04 Start Date: 25/Apr/23 18:04 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4447: URL: https://github.com/apache/activemq-artemis/pull/4447#discussion_r1176860418 ########## docs/user-manual/en/client-reconnection.md: ########## @@ -89,9 +89,20 @@ Client reconnection is configured using the following parameters: ridiculously large values. By setting this parameter you can set an upper limit on that value. The default value is `2000` milliseconds. +- `ha`. This optional parameter determines weather the client will try to + reconnect to the backup node when the live node is not reachable. + The default value is `false`. + For more information on HA, please see [High Availability and Failover](ha.md). + - `reconnectAttempts`. This optional parameter determines the total number of - reconnect attempts to make before giving up and shutting down. A value of - `-1` signifies an unlimited number of attempts. The default value is `0`. + reconnect attempts to make to the current live/backup pair before giving up. Review Comment: Yeah, could probably do with some docs to clarify what specifically is a 'reconnect attempt' vs a 'failover attempt' and thus help show when you would use one/other/both, for those that dont already know the previous/existing behaviour and thus also wont be able tell later which one of these is the new option/behaviour (/me raises hand). (E.g, in other clients I know, there is only one notion of 'attempts', where I believe generally they retry the server originally connected to again and then try all the other servers currently known about until succeeding, then repeat [after delay] if still not connected...with that one-shot-at-each-server process collectively being '1 attempt') Issue Time Tracking ------------------- Worklog Id: (was: 858998) Time Spent: 40m (was: 0.5h) > Support CORE client failover to other live servers > -------------------------------------------------- > > Key: ARTEMIS-4251 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4251 > Project: ActiveMQ Artemis > Issue Type: Improvement > Reporter: Domenico Francesco Bruscino > Assignee: Domenico Francesco Bruscino > Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > The CORE clients support failover only reconnecting to the current > live/backup pair. Improve the CORE client failover connecting to other live > servers when all reconnect attempts fails, i.e. in a cluster composed of 2 > live servers, when the server to which the CORE client is connected goes down > the CORE client should reconnect its sessions to the other liver broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)