[
https://issues.apache.org/jira/browse/ARTEMIS-4267?focusedWorklogId=860386&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860386
]
ASF GitHub Bot logged work on ARTEMIS-4267:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/23 16:26
Start Date: 03/May/23 16:26
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #4461:
URL: https://github.com/apache/activemq-artemis/pull/4461#discussion_r1183927642
##########
artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/ActiveMQJAASSecurityManager.java:
##########
@@ -141,8 +141,10 @@ private Subject getAuthenticatedSubject(final String user,
try {
lc.login();
} catch (LoginException e) {
- Throwable rootCause = ExceptionUtil.getRootCause(e);
+ Throwable rootCause = ExceptionUtils.getRootCause(e);
if (rootCause instanceof NoCacheLoginException) {
+ // preserve the original exception for logging
+ rootCause.initCause(e);
Review Comment:
Could the inversion be avoided if the `SecurityStoreImpl` would use
`ExceptionUtils.getRootCause(e)` to check that the root cause is
`NoCacheLoginException`?
Issue Time Tracking
-------------------
Worklog Id: (was: 860386)
Time Spent: 50m (was: 40m)
> Original exception lost for NoCacheLoginException
> -------------------------------------------------
>
> Key: ARTEMIS-4267
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4267
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Fix For: 2.29.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When skipping the authentication cache the _original_ exception is not logged.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
