[
https://issues.apache.org/jira/browse/ARTEMIS-4267?focusedWorklogId=860796&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860796
]
ASF GitHub Bot logged work on ARTEMIS-4267:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/May/23 16:36
Start Date: 05/May/23 16:36
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #4461:
URL: https://github.com/apache/activemq-artemis/pull/4461#discussion_r1186293356
##########
artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/ActiveMQJAASSecurityManager.java:
##########
@@ -141,8 +141,9 @@ private Subject getAuthenticatedSubject(final String user,
try {
lc.login();
} catch (LoginException e) {
- Throwable rootCause = ExceptionUtil.getRootCause(e);
+ Throwable rootCause = ExceptionUtils.getRootCause(e);
if (rootCause instanceof NoCacheLoginException) {
+ logger.debug("Handling LoginException with
NoCacheLoginException root cause", e);
Review Comment:
We don't need a new interface because classes implementing an interface
don't have to throw exceptions defined in the interface. So current
implementations of ActiveMQSecurityManager5 will work also if we add the trwows
NoCacheLoginException to the `authenticate` method.
Issue Time Tracking
-------------------
Worklog Id: (was: 860796)
Time Spent: 2.5h (was: 2h 20m)
> Original exception lost for NoCacheLoginException
> -------------------------------------------------
>
> Key: ARTEMIS-4267
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4267
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Fix For: 2.29.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> When skipping the authentication cache the _original_ exception is not logged.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
