[
https://issues.apache.org/jira/browse/ARTEMIS-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726251#comment-17726251
]
Roelof Naude commented on ARTEMIS-4291:
---------------------------------------
in short yes.
in addition we have timing issue in that the plugin init is called fairly early
before MetricsManager have had a chance to setup the common tags. any metrics
created / registered before then will not have the "broker" tag added as well.
for that reason the new "bind" method was added.
> Some metrics do not have the "broker" tag
> -----------------------------------------
>
> Key: ARTEMIS-4291
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4291
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.28.0
> Reporter: Roelof Naude
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Some metrics do not have the "broker" tag. The "broker" may not match the
> "instance" added by e.g. prometheus, leading to a mismatch.
> [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java]
> should ideally add "broker" to the common tags, e.g:
> {code:java}
> meterRegistry.config().commonTags("broker", brokerName);{code}
>
> [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted
> to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
