[
https://issues.apache.org/jira/browse/ARTEMIS-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728087#comment-17728087
]
ASF subversion and git services commented on ARTEMIS-4291:
----------------------------------------------------------
Commit 40425d422abe8e6121510a5f7bb18af12c22f147 in activemq-artemis's branch
refs/heads/main from Roelof Naude
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=40425d422a ]
ARTEMIS-4291 Add the "broker" tag in a consistent manner to all exported
metrics.
Some scrapers, e.g. prometheus, add an "instance" tag. This value may not be
the same as
the broker name, which results in these metrics becoming more difficult to
match up with
the corresponding broker.
> Some metrics do not have the "broker" tag
> -----------------------------------------
>
> Key: ARTEMIS-4291
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4291
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.28.0
> Reporter: Roelof Naude
> Priority: Minor
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Some metrics do not have the "broker" tag. The "broker" may not match the
> "instance" added by e.g. prometheus, leading to a mismatch.
> [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java]
> should ideally add "broker" to the common tags, e.g:
> {code:java}
> meterRegistry.config().commonTags("broker", brokerName);{code}
>
> [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted
> to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
