[ 
https://issues.apache.org/jira/browse/ARTEMIS-4362?focusedWorklogId=870753&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870753
 ]

ASF GitHub Bot logged work on ARTEMIS-4362:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Jul/23 10:00
            Start Date: 13/Jul/23 10:00
    Worklog Time Spent: 10m 
      Work Description: gtully commented on code in PR #4552:
URL: https://github.com/apache/activemq-artemis/pull/4552#discussion_r1262329262


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java:
##########
@@ -1584,4 +1584,7 @@ void slowConsumerDetected(String sessionID,
 
    @LogMessage(id = 224126, value = "Failure during protocol handshake on 
connection to {} from {}", level = LogMessage.Level.ERROR)
    void failureDuringProtocolHandshake(SocketAddress localAddress, 
SocketAddress remoteAddress, Throwable e);
+
+   @LogMessage(id = 224127, value = "Queue {}/Address {} is currently 
delivering {} messages that are holding {} bytes, with max reading sizes 
configured as addressSettings.maxPageReadMessages={} and 
addressSettings.maxPageReadBytes={}. System will not read more data from paging 
until acks are made. You can increase the address settings page-max-read 
attributes or make sure your consumers use lower batch sizes.", level = 
LogMessage.Level.WARN)

Review Comment:
   it is only reading to dispatch, from a user perspective, dispatch is 
blocked. it is transient, but for a new consumer on a queue with pending 
messages, that is the disconnect that we want to fill with the logging.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 870753)
    Time Spent: 1h 20m  (was: 1h 10m)

> Produce a logger when consumers are holding too many messages not allowing 
> deposing
> -----------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-4362
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4362
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Clebert Suconic
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> We should add a log.warn whenever the system can't read more messages because 
> consumers are holding too many messages in pending state.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to