[
https://issues.apache.org/jira/browse/ARTEMIS-4362?focusedWorklogId=870771&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870771
]
ASF GitHub Bot logged work on ARTEMIS-4362:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/23 10:50
Start Date: 13/Jul/23 10:50
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4552:
URL: https://github.com/apache/activemq-artemis/pull/4552#discussion_r1262384468
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -179,6 +179,14 @@ public class QueueImpl extends CriticalComponentImpl
implements Queue {
private volatile boolean queueDestroyed = false;
+ // Variable to control if we should print a flow controlled message or not.
+ // Once it was flow controlled, we will stop warning until it's cleared
once again
+ private volatile boolean pageFlowControlled = false;
+
+ private volatile long pageFlowControlledLastLog = 0;
+
+ private static final long PAGE_FLOW_CONTROL_PRINT_INTERVAL = 60_000L;
Review Comment:
I was trying to avoid another configuration attribute in broker.xml.
the system will always try to depage when a new consumer is added.. yeah.
Reason I made it WARN was : first I was in doubt which level I should
use.... as I talked to a few users they usually ignore anything bellow WARN and
will only get notifications when WARN is used.
Issue Time Tracking
-------------------
Worklog Id: (was: 870771)
Time Spent: 1.5h (was: 1h 20m)
> Produce a logger when consumers are holding too many messages not allowing
> deposing
> -----------------------------------------------------------------------------------
>
> Key: ARTEMIS-4362
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4362
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Clebert Suconic
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> We should add a log.warn whenever the system can't read more messages because
> consumers are holding too many messages in pending state.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
