[
https://issues.apache.org/jira/browse/ARTEMIS-4159?focusedWorklogId=873161&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873161
]
ASF GitHub Bot logged work on ARTEMIS-4159:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/23 20:17
Start Date: 26/Jul/23 20:17
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4569:
URL: https://github.com/apache/activemq-artemis/pull/4569#discussion_r1275442878
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##########
@@ -1797,6 +1817,8 @@ public void encode(ActiveMQBuffer buffer) {
BufferHelper.writeNullableLong(buffer, pageLimitMessages);
+ BufferHelper.writeNullableInteger(buffer, idCacheSize);
Review Comment:
Both the read and the write for the `idCacheSize` should be at the *end*
otherwise the broker may choke on existing persisted address settings when
upgrading.
Issue Time Tracking
-------------------
Worklog Id: (was: 873161)
Time Spent: 1h 20m (was: 1h 10m)
> Support duplicate cache size configuration per address
> ------------------------------------------------------
>
> Key: ARTEMIS-4159
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4159
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Justin Bertram
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> As an administrator, and since each address already has its own cache-id, I
> would like to be able to have a id-cache-size configured per address (which
> will default to the global setting in case it doesn't exist).
> Motivation: we currently have a quite large number of address, and each
> address has different id-cache-size requirements. Today, to implement that,
> we have to deploy several instances.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
