[
https://issues.apache.org/jira/browse/ARTEMIS-4159?focusedWorklogId=874521&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-874521
]
ASF GitHub Bot logged work on ARTEMIS-4159:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Aug/23 22:55
Start Date: 03/Aug/23 22:55
Worklog Time Spent: 10m
Work Description: fartzy commented on code in PR #4569:
URL: https://github.com/apache/activemq-artemis/pull/4569#discussion_r1283794559
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java:
##########
@@ -1456,6 +1458,10 @@ protected Pair<String, AddressSettings>
parseAddressSettings(final Node node) {
addressSettings.setEnableMetrics(XMLUtil.parseBoolean(child));
} else if (ENABLE_INGRESS_TIMESTAMP.equalsIgnoreCase(name)) {
addressSettings.setEnableIngressTimestamp(XMLUtil.parseBoolean(child));
+ } else if (ID_CACHE_SIZE.equalsIgnoreCase(name)) {
+ int idCacheSize = XMLUtil.parseInt(child);
+ Validators.GT_ZERO.validate(ID_CACHE_SIZE, idCacheSize);
Review Comment:
Yeah makes sense! changed to `Validators.GE_ZERO`
Issue Time Tracking
-------------------
Worklog Id: (was: 874521)
Time Spent: 2h 10m (was: 2h)
> Support duplicate cache size configuration per address
> ------------------------------------------------------
>
> Key: ARTEMIS-4159
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4159
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Justin Bertram
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> As an administrator, and since each address already has its own cache-id, I
> would like to be able to have a id-cache-size configured per address (which
> will default to the global setting in case it doesn't exist).
> Motivation: we currently have a quite large number of address, and each
> address has different id-cache-size requirements. Today, to implement that,
> we have to deploy several instances.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
